Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typing.Dict for typing in conftest #2900

Merged

Conversation

johannaengland
Copy link
Contributor

This can be reverted as soon as we drop support for Python 3.7.
Therefore related to #2790.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.23%. Comparing base (30ba222) to head (4f10744).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2900   +/-   ##
=======================================
  Coverage   60.23%   60.23%           
=======================================
  Files         602      602           
  Lines       44050    44050           
=======================================
  Hits        26534    26534           
  Misses      17516    17516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 7, 2024

Test results

     12 files       12 suites   11m 29s ⏱️
3 320 tests 3 320 ✔️ 0 💤 0
9 435 runs  9 435 ✔️ 0 💤 0

Results for commit 8138a57.

@johannaengland johannaengland force-pushed the bugfix/fix-typing-dict branch from 8138a57 to 4f10744 Compare May 15, 2024 12:17
@johannaengland johannaengland merged commit cf75409 into Uninett:master May 15, 2024
10 of 11 checks passed
@johannaengland johannaengland deleted the bugfix/fix-typing-dict branch May 15, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants